fix: change sequence import (#1915) #1916
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @kiryazb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a compatibility issue affecting Python 3.7 and 3.8 environments. By adjusting how the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a TypeError on Python 3.7 and 3.8 caused by using collections.abc.Sequence for type hinting, which is not subscriptable in those versions. The fix correctly switches to importing Sequence from the typing module, ensuring compatibility. The change is minimal, correct, and effectively resolves the issue. I have no further suggestions.
|
This was addressed in #1918. Thanks! |
2 participants
Fixes #1915
What
Fix
TypeError: 'ABCMeta' object is not subscriptableon Python 3.7/3.8 by avoidingcollections.abc.Sequence[str]usage during import.How
Switch typing annotations to use
typing.Sequence(or use postponed evaluation of annotations) to keep compatibility with Python 3.7/3.8.